signalfx / signalfx-k8s-metrics-adapter

Horizontal Pod Autoscaler custom/external metrics provider for Kubernetes that uses SignalFx as the backend
Apache License 2.0
9 stars 15 forks source link

Add minimum expiry duration for timeseries #11

Closed keitwb closed 4 years ago

keitwb commented 4 years ago

It can be set on the command line as a flag and will act as a minimum time to wait after the last received data for a timeseries before expiring that timeseries from the job runner.

This is useful if you have fast jobs where data might sometimes get sporatic or delayed and you don't want the timeseries to expire and cause an error in the K8s HPA system.

keitwb commented 4 years ago

changes LGTM, not sure why CI is failing?

Timeouts are too short I think. Trying to see if extending them helps.