signalfx / signalfx-k8s-metrics-adapter

Horizontal Pod Autoscaler custom/external metrics provider for Kubernetes that uses SignalFx as the backend
Apache License 2.0
10 stars 15 forks source link

Add timeout for signalflow metadata request #41

Closed danielcoleAL closed 7 months ago

danielcoleAL commented 7 months ago

I've found that if an external metrics SignalFlow query is defined with errors it will cause the API to hang, ultimately causing the entire external metrics API to fail for all HPAs.

The timeout seems to have been removed in https://github.com/signalfx/signalfx-k8s-metrics-adapter/pull/32. This adds it back in and allows for the API to continue functioning even if there's a bad query defined.