sanitize labels so it replaces / or . with _

signalfx / signalfx-k8s-metrics-adapter

Horizontal Pod Autoscaler custom/external metrics provider for Kubernetes that uses SignalFx as the backend

Apache License 2.0

10 stars 15 forks source link

sanitize labels so it replaces / or . with _ #6

Closed mzq592 closed 5 years ago

mzq592 commented 5 years ago

Summay Both Yelp's own collector and signalfx-agent replaces '/' or '.' with '_' . I think the adapter should do it as well. Otherwise our labels like 'yelp.com/xx' doesn't work.

mzq592 commented 5 years ago

I think the failed test is flaky. Could you rerun it? I don't have permission.

keitwb commented 5 years ago

@EmanekaT thanks for this. Yes, this is the appropriate behavior since dimension/property names in SignalFx can never have / or . in them. That means there is also no concern about this breaking any existing users of the adapter.

The test is kind of flaky but I'm going to try and fix it and ensure that it really isn't related to your change (I reran it and it failed again). Will update here when I'm done.

keitwb commented 5 years ago

Ok, this was merged and released in 0.3.0. Thanks again.