signalfx / splunk-otel-collector-chart

Splunk OpenTelemetry Collector for Kubernetes
Apache License 2.0
120 stars 150 forks source link

Increase default livenessProbe.initialDelaySeconds to 10 minutes #1412

Closed johngmyers closed 2 months ago

johngmyers commented 2 months ago

Description:

Increases the default for livenessProbe.initialDelaySeconds.

When the on-disk queue grows sufficiently, the agent pod enters a crashloop, with the liveness probe restarting the pod before it finishes startup. The agent pod is thus prevented from uploading any of the data in the queue.

The defaults should be chosen to avoid such problems.

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

github-actions[bot] commented 2 months ago


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

johngmyers commented 2 months ago

I am not authorized to sign license agreements on behalf of my employer.

jvoravong commented 2 months ago

The requested feature is already supported through user input in the values.yaml file. Closing this PR.

jvoravong commented 2 months ago

Perhaps this PR may have been intended for a fork rather than the main repository: https://github.com/signalfx/splunk-otel-collector-chart