signalfx / splunk-otel-go

Splunk Distribution of OpenTelemetry Go
https://docs.splunk.com/Observability/gdi/get-data-in/application/go/get-started.html
Apache License 2.0
49 stars 21 forks source link

`splunkchi`: Support `github.com/go-chi/chi/v5` #316

Open pellared opened 2 years ago

pellared commented 2 years ago

https://github.com/go-chi/chi released v5 some time ago which we should support.

joshi-kamitsukasa commented 1 year ago

We want to use v5 too. Please support it.

pellared commented 1 year ago

You can consider using https://pkg.go.dev/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and use its RouteTag option or https://pkg.go.dev/github.com/riandyrn/otelchi.

You can also take a look at https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4017 for inspiration how otelhttp could be used with github.com/go-chi/chi/v5