signalfx / splunk-otel-js

Splunk Distribution of OpenTelemetry JavaScript
https://docs.splunk.com/Observability/gdi/get-data-in/application/nodejs/get-started.html
Apache License 2.0
23 stars 13 forks source link

feat: support node21 for prebuilds #838

Closed seemk closed 1 year ago

seemk commented 1 year ago

Prebuild the native module for Node 21.

Plus workaround for https://github.com/nodejs/node-gyp/issues/2869

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (394a79b) 86.22% compared to head (58ff63b) 86.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #838 +/- ## ======================================= Coverage 86.22% 86.22% ======================================= Files 19 19 Lines 668 668 Branches 153 153 ======================================= Hits 576 576 Misses 92 92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m-tu commented 1 year ago

LGTM