signalpillar / tox-battery

Experiments with Tox plugin system
MIT License
33 stars 3 forks source link

Handle `--requirement` argument, not just `-r` #18

Open Zac-HD opened 5 years ago

Zac-HD commented 5 years ago

https://github.com/signalpillar/tox-battery/blob/110c931c4cb7b803f2637f8f4a0feae1593f5522/toxbat/requirements.py#L158-L160

is great, but doesn't handle the long-form option:

[testenv:test]
deps =
    --no-deps
    --requirement deps/test.txt

This would be a good issue for someone to handle for Hacktoberfest 😄

signalpillar commented 5 years ago

@Zac-HD indeed it doesn't. Thank you for reporting.

I haven't seen usage of --no-deps before. Does tox config skipsdist work for you?

Zac-HD commented 5 years ago

No problem :smile:

--no-deps means "install exactly the packages listed, and nothing else - not even their dependencies". It's obviously only useful with lockfiles, but important in case e.g. your lockfile was missing something which would then not be properly locked. So tox's skipsdist is really a separate thing - --no-deps isn't related to this issue, it's just something I have in my config.

While I think about it, it would be good to handle all of the following cases - currently only file1.txt-style is supported:

[testenv]
deps =
    -rfile1.txt
    -r file2.txt
    -r=file3.txt
    --requirement file4.txt
    --requirement=file5.txt