signalpoint / DrupalGap

An application development kit for Drupal websites.
https://www.drupalgap.org
GNU General Public License v2.0
231 stars 185 forks source link

Deprecate variable_* functions in favor of local_variable_* functions #644

Open signalpoint opened 8 years ago

signalpoint commented 8 years ago

The variable_set, variable_get and variable_del functions are a bit misleading because they have nothing to do with Drupal's functions named the exact same thing. Our functions only deal with local storage, so rename them as such. Deprecate the latter functions with a warning and forwarder. This fix will come with jDrupal, since these functions are being moved there.

signalpoint commented 8 years ago

@eduoda ping, FYI. I will be moving these functions into jDrupal and renaming them accordingly. I noticed your new jDrupal branch uses these functions, but they are only available in DrupalGap... ?

eduoda commented 8 years ago

@signalpoint sorry, I didn't notice it. It will be nice to have them in jDrupal

signalpoint commented 8 years ago

@eduoda No problem, thanks for the follow up.