search

signalpoint / jDrupal

A JavaScript Library and API for Drupal Applications
http://jdrupal.tylerfrankenstein.com/
GNU General Public License v2.0
76 stars 38 forks source link

Multiple definitions of entity_delete() #58

Closed jacobembree closed 7 years ago

jacobembree commented 7 years ago

entity_delete() is defined in src/entity.js and src/services/services.entity.js

src/entity.js entity_delete() calls entity_type + '_delete'. src/services/services.entity.js entity_delete() uses Drupal.services.call().

I believe the one in services.entity.js overwrites the one in entity.js, so should the one in entity.js simply be removed?

signalpoint commented 7 years ago

@jacobembree Yes, great catch, thank you.