search

signalpoint / push_notifications

The Push Notifications module for DrupalGap.
0 stars 10 forks source link

Push notification not working for android #3

Closed kiss-jozsef closed 8 years ago

kiss-jozsef commented 9 years ago

If you have an android device and try to register it push_notifications_platform_token function return null so the push_notificiations_create will return error i added an extra case for android case "Android": token = 'android'; break; and this solves it

signalpoint commented 9 years ago

@kiss-jozsef Excellent, thank you. Please fork this repository, and submit a pull request with the fix, and we can merge it in for your contribution!

ptmkenny commented 9 years ago

@kiss-jozsef Did this fix ever get added to the push_notifications project?

kiss-jozsef commented 9 years ago

@ptmkenny yes it was added

ptmkenny commented 9 years ago

@kiss-jozsef Ok, thanks. Just wanted to check because this issue was never marked resolved.

signalpoint commented 8 years ago

This module has since been updated heavily and well documented, this should no longer be an issue.