signalwire-community / signalwire-php

PHP Library for SignalWire APIs
https://signalwire-community.github.io/docs/php/
MIT License
22 stars 26 forks source link

Compatibility issues with laravel 6.x, (monolog/monlog 2.x) #105

Closed binaryweavers closed 4 years ago

binaryweavers commented 4 years ago

Trying to install signalwire-php v2.x in laravel 6.x which uses monolog 2.x but it seems signalwire-php requires monolog 1.x

Composer Feedback


composer require signalwire/signalwire
Using version ^2.3 for signalwire/signalwire
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1

Installation failed, reverting ./composer.json to its original content.

edolix commented 4 years ago

Hi @binaryweavers! We'll release a patch version soon to allow monolog ^2 πŸ‘

binaryweavers commented 4 years ago

Hi @binaryweavers! We'll release a patch version soon to allow monolog ^2 πŸ‘

I was looking at your src/Log.php and I think it won't have any breaking changes. I have also downgraded monolog in my project from 2.x to 1.x for now as I saw in laravel src, there was a choice between monlog 1.24 | 2.0 Yet having SignalWire with proper version will avoid future issues πŸ‘

edolix commented 4 years ago

I tested our \SignalWire\Log with 2.x and it works as expected. The main breaking change in monolog 2.x is the PHP version (min to 7.2)

binaryweavers commented 4 years ago

Oh Thanks for this piece of info. I didn't notice that as I am using php v7.4. Will use proper patch of SignalWire-php as soon it's available.