search

signalwire-community / signalwire-php

PHP Library for SignalWire APIs
https://signalwire-community.github.io/docs/php/
MIT License
22 stars 26 forks source link

Can't use latest twilio/sdk package #110

Closed elijahchancey closed 4 years ago

elijahchancey commented 4 years ago

I'd like to upgrade from twilio/sdk from 5.41.1 to 6.3.0. Signalwire appears to require the old version. Can signalwire support the new sdk version? Thanks!

edolix commented 4 years ago

@elijahchancey we are reviewing the changes required for the upgrade but no ETA yet! Thanks!

elijahchancey commented 4 years ago

@edolix Any updates? Thanks!

edolix commented 4 years ago

@elijahchancey i've no updates yet. I'll close this issue once the new release is out! Thanks

cshanejennings commented 4 years ago

Update? I have the same issue

edolix commented 4 years ago

Hi @cshanejennings , we are currently reviewing some internal changes to all the SDKs but i have no ETA. I will update this issue with more info soon as possible. Thanks!

derikb commented 4 years ago

Well this is problematic. We were planning on starting to use signalwire in addition to twilio (which we already use), but I can't even install the sdk since our Twilio package is already past the minimum required for this. If the goal is "make it easier to switch from Twilio by using the same API" this is a pretty large problem.

bryanrite commented 4 years ago

@derikb Unfortunately the latest Twilio SDKs have changed their internals and we haven't had a chance to make this compatible with SignalWire, maintaining backwards compatibility is the main reason this can take so long and unfortunately their changes did not make this straight forward update.

derikb commented 4 years ago

@bryanrite Well it makes switching over pretty hard. Since I can't in php run two version of the same package at the same time.

emcgee commented 4 years ago

@derikb We're having someone take a look over it as well, but if you're open to submitting a pull request we'd be more than happy to review and get it merged!

derikb commented 4 years ago

@emcgee How would I submit a pull request. Isn't the issue that the twilio code and the signalwire api are no longer compatible? Neither of those seem to be things I could fix in this repo.

emcgee commented 4 years ago

The APIs are still fully compatible - the issue at hand is simply that Twilio updated their library and changed a few function calls. The fix is to upgrade the Twilio dependency library and then adjust the code here to match the new methods and run the test suite to guarantee it's all 💯

We're taking a look over at https://github.com/signalwire/signalwire-php/pull/112

bryanrite commented 4 years ago

Version 2.3.7 of our SDK supports Twilio SDK Version 6+... I'm pushing this up to Packagist now.

derikb commented 4 years ago

Thanks @bryanrite