search

signalwire-community / signalwire-php

PHP Library for SignalWire APIs
https://signalwire-community.github.io/docs/php/
MIT License
22 stars 26 forks source link

PHP 8 support #117

Closed janisblaus closed 2 years ago

janisblaus commented 3 years ago

Hi.

We are using php 8, current package does not support it by dependency from recoil/react.

bryanrite commented 3 years ago

Hi @janisblaus, you're correct, we're currently blocked on supporting PHP 8 due to our dependancy on https://github.com/recoilphp/recoil/issues/168

We're watching the repository closely, and as soon as there is support, we'll upgrade this SDK.

JWinters88 commented 3 years ago

Is this still blocked? There is renewed interest about this.

derikb commented 3 years ago

That was me, though I am much more concerned about #118

derikb commented 2 years ago

fwiw recoil has updated to 1.0.2 which supports php 7.4 and php8

EricPaulson commented 2 years ago

@bryanrite, now that Recoil supports PHP 8, can you add support for PHP 8 to this project? Much appreciated!

bryanrite commented 2 years ago

@EricPaulson Thanks for the ping! We'll check this out ASAP.

ryann commented 2 years ago

much appreciated bryan

EricPaulson commented 2 years ago

@bryanrite Any word on getting this merged?

bryanrite commented 2 years ago

Hey @EricPaulson, there is a WIP PR #122, ran into some PHPUnit changes on the test suite we have to fix up before releasing. We'll be finishing this soon.

SagarNaliyapara commented 2 years ago

any update? waiting for PHP 8 support ❤️ @bryanrite

uglydawg commented 2 years ago

I'm also waiting for PHP 8 support.

bryanrite commented 2 years ago

Looks like the blocker on one of the dependencies was fixed last week, so we should be good to go on continuing this.

edolix commented 2 years ago

We released the v3.0.0 of the new https://packagist.org/packages/signalwire-community/signalwire#v3.0.0 package to support PHP8! 👍

SagarNaliyapara commented 2 years ago

Thank you so much @edolix