search

signalwire / freeswitch

FreeSWITCH is a Software Defined Telecom Stack enabling the digital transformation from proprietary telecom switches to a versatile software implementation that runs on any commodity hardware. From a Raspberry PI to a multi-core server, FreeSWITCH can unlock the telecommunications potential of any device.
https://freeswitch.com/#getting-started
Other
3.6k stars 1.42k forks source link

IPv6 address values missing in HEP packet #1535

Open hamidrhashmi opened 2 years ago

hamidrhashmi commented 2 years ago

Describe the bug I have noticed that Homer server is not showing IPv6 IPs but only IPv4. When I took traces for HEP packet I have found that FS server is not sending IPv6 IP in HEP Packet.

To Reproduce

  1. Freeswitch server must have an IPv6
  2. Enable capture-server settings
  3. take pcap traces. FS-1 10 7-IPv6-HEP-Packet2

Expected behavior HEP headers Source IPv6 address and Destination IPv6 Address must have correct ipv6 values. Package version or git hash

dragos-oancea commented 2 years ago

you should discuss this with the homer guys and send them our regards ! https://github.com/sipcapture/homer

lmangani commented 2 years ago

Hi @dragos-oancea thanks for the kind regards :) @hamidrhashmi is one of the "HOMER guys" (part of our support team) Are you suggesting we should patch this in core FS?

dragos-oancea commented 2 years ago

Hi Lorenzo ! It's probably the sofia lib that needs patching (https://github.com/freeswitch/sofia-sip) .

I see commit d3ded130a92f32337bee992200a06830678b2d5b added HEP2 & HEP3 support.

lmangani commented 2 years ago

Not sure if we have the resources to do this, it doesn't appear to be trivial but I'll check with @adubovikov

adubovikov commented 2 years ago

@dragos-oancea can we do PR here ?

dragos-oancea commented 2 years ago

The sofia lib has been moved out of FS tree - see the URL above. If you need changes for mod_sofia do them here, on this repo, yes. Core changes will be harder to merge, if you can patch the lib or mod_sofia it will be better.

adubovikov commented 2 years ago

I have rechecked the code one more time and for me it looks (from logic and style) correct. https://github.com/adubovikov/sofia-sip/blob/master/libsofia-sip-ua/tport/tport_logging.c#L674-L689

@hamidrhashmi please provide hep.pcap for analyze - probably it's an issue with lua parser.