signalwire / signalwire-js

MIT License
18 stars 15 forks source link

Allow unsubscribe from the conversation subscribe API #1108

Closed iAmmar7 closed 2 months ago

iAmmar7 commented 2 months ago

Description

The PR will allow the user to unsubscribe from the conversation API.

Type of change

Code snippets

const { unsubscribe } = await client.conversation.subscribe(() => { ... })
unsubscribe();
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 68cb07994af4560c8d928ef77ad96a5146f652df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @signalwire/js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

iAmmar7 commented 2 months ago

@jpsantosbh sure, I will create a PR over there as well.

Could you please review this one more time? I have just updated the variable name and if condition for consistency.