search

signalwire / signalwire-js

MIT License
18 stars 15 forks source link

Add a `simpleVideoElement` param #1135

Closed jpsantosbh closed 1 month ago

jpsantosbh commented 1 month ago

Description

Add a simpleVideoElement param to disable the Video element aspect ratio handling explicitly. Before, this behavior was implicitly defined by not enabling any overlay. But it's valid to avoid overlay, and we still want the SDK to maintain the video aspect ratio.

Type of change

Code snippets

buildVideoElement({ room, rootElement: mockRootEl, simpleVideoElement })
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: eed1763f86163357bff2d8a4e8789edafa1bdd71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jpsantosbh commented 1 month ago

@iAmmar7, please rename the variable in your PR once you merge this to your branch.