search

signalwire / signalwire-ruby

MIT License
9 stars 11 forks source link

Blade error handling #42

Closed lpradovera closed 5 years ago

lpradovera commented 5 years ago

Resolution for #41 . Needs reviewing. @bryanrite , in your opinion would it be ok to let promises time out on an error? That way I could move the error handling one level up. Otherwise, it needs to be handled case-by-case as in this initial implementation. This does already stop the client from progressing if the Relay setup fails.

lpradovera commented 5 years ago

Handling #36 chore too.

bryanrite commented 5 years ago

I'm not sure I understand what you're asking. Code examples?

lpradovera commented 5 years ago

@bryanrite this should be GTG, it handles errors in a clearer way and we should iterate on this further while we work on other features.