Closed vpnagraj closed 3 years ago
I agree, solve it in get_deaths, bound to zero there. Hopefully the fluctuations and reporting corrections are very minor and shouldn't have much impact. Only thing here... when we're getting down to county level granularity we're definitely going to run into the problem you noted before somewhere else, that these things weren't designed for count data. https://otexts.com/fpp3/counts.html suggests this is no problem once you're far enough away from zero, but we won't be at county levels. We might be at state levels with deaths if/when things start to wind down again.
good points. but yeah to clarify, i'm not suggesting we use the TS models at the county level.
i ran into this while playing around with trendeval
package and count regression over here https://github.com/signaturescience/focustools/commit/bebb1c23e4c5f7c686af04d9e79eaf8852f45d5c
related to https://github.com/signaturescience/focustools/issues/27
resolved via #38
when we pull data from JHU or NYT we start with cumulative data and untangle that to calculate incident counts
looks like on the county level (and probably on state/national scale too) there are some weeks when the cumulative reporting has been adjusted to have fewer cases or deaths the following week
the result is that you can have negative incident counts. i noticed this at the county level:
best way to handle this? probably in get_ functions. we can bound ideaths/icases at 0 there. but i'm not sure that we should change cdeaths/ccases given that those are* the reports. but certainly doesn't make sense to count incident cases as negative!