search

signaturescience / focustools

Forecasting COVID-19 in the US
https://signaturescience.github.io/focustools/
GNU General Public License v3.0
0 stars 0 forks source link

submission script edits #44

Closed vpnagraj closed 3 years ago

vpnagraj commented 3 years ago

this PR will bring in some edits to the submission/submission.R script that will make it usable in the AWS pipeline as-is

i tweaked couple of the paths in the S3 bucket and made some minor changes to the bootstrap script as well.

@stephenturner when you get a chance confirm that you're good with this interactively.

of note, the script does generate a submission output on non-mondays

it also will save a "validation file" (captured output from validation script), forces install of py deps during validation, and will write out the plot_forecast() pdf to submissions

if interactive it will perform the "bad states" check. i kept that condition so that we can optionally exclude states from the automated pipeline after we review the output.

vpnagraj commented 3 years ago

sounds good. i didnt like that force install behavior interactively so im glad you fixed it.

big picture is that this script synchronizes us in terms of the pipeline and what we have in GH.

thats not totally sorted yet. we still need to figure out how to clone this repo (currently private) to the automated instance. first step is to get this merged though ...