search

signaturescience / focustools

Forecasting COVID-19 in the US
https://signaturescience.github.io/focustools/
GNU General Public License v3.0
0 stars 0 forks source link

adding CI for pkg build #55

Closed vpnagraj closed 3 years ago

vpnagraj commented 3 years ago

@stephenturner take a look.

slightly more sophisticated but still very similar to the other repo where we are using GH actions for pkg check

two workflow yaml files that basically do the same things but are triggered by pushes to different branches. splitting out this way means we can track the build status for stable (main or master) versus dev (anything but those two)

also building on an ubuntu runner instead of mac. had to add a line to install system dependencies for curl

stephenturner commented 3 years ago

You probably know this but there's a note:

❯ checking dependencies in R code ... NOTE
  Namespaces in Imports field not imported from:
    ‘lifecycle’ ‘shinyWidgets’
    All declared Imports should be used.
vpnagraj commented 3 years ago

we talked about this on the call. for posterity:

i used usethis::use_github_action_check_release() , which stubs out the workflow yaml. i copied that template to another file, used one for stable one and the other for the dev workflow

also re: the NOTE ...

the GH action workflow uses rcmdcheck::rcmdcheck (see https://github.com/signaturescience/focustools/blob/pkg-build-ci/.github/workflows/R-CMD-check-dev.yaml#L30), which must have a slightly different behavior that devtools::check() in terms of what goes in Imports vs Suggests

i just made the change suggested in that NOTE: 6316aad