signaturescience / rplanes

R package to conduct plausibility analysis of epidemiological signals
https://signaturescience.github.io/rplanes/
Other
8 stars 3 forks source link

Check for plane_shape documentation issues #143

Closed abenefield1 closed 4 months ago

abenefield1 commented 4 months ago

Checking/fixing/adding documentation that might have been impacted by the new plane_shape() method. Here are the places I can think to check, but let me know if you think of any others:

abenefield1 commented 4 months ago

@vpnagraj - I think I caught all places where documentation needed to be updated. Also, I found an error in the interpretation vignette that I pushed back to dev. See details and further suggestions below:

vpnagraj commented 4 months ago

thanks @abenefield1 .

ive addressed the relevant items mentioned above:

also reminder to always make sure to run devtools::check() on the package when adding new features (even updates to documentation!) ... turns out that we ran into a pesky character limit in one of the examples with one of your commits. here were the check results:

── R CMD check results ───────────────────────────────────────────────────────────────────────────────────────── rplanes 0.0.3.9000 ────
Duration: 1m 2.6s

❯ checking Rd line widths ... NOTE
  Rd file 'plane_score.Rd':
    \examples lines wider than 100 characters:
       comp_args <- list("trend" = list("sig_lvl" = 0.05), "repeat" = list("prepend" = 4, "tolerance" = 8), "shape" = list("method" = "dtw"))

comp_args <- list("trend" = list("sig_lvl" = 0.05), "repeat" = list("prepend" = 4, "tolerance" = 8), "shape" = list("method" = "dtw"))

its a NOTE which would require an explanation for CRAN review. to get around that i broke up the comp_args object definition into a few separate lines (https://github.com/signaturescience/rplanes/pull/145/commits/fcdfc4d604b9ea06b2abdd8a51bb18abb02c74a5) ... check is coming through clean now (no NOTEs, WARNINGs, or ERRORs)