search

signaturescience / skater

SKATE R Utilities
https://signaturescience.github.io/skater/
Other
9 stars 4 forks source link

Add simple CI #13

Closed stephenturner closed 3 years ago

stephenturner commented 3 years ago

See https://github.com/r-lib/actions/tree/master/examples#quickstart-ci-workflow

Looks as simple as

usethis::use_github_action("check-release")
stephenturner commented 3 years ago

@vpnagraj @genignored turns out this couldn't have been simpler. This added everything needed to run a simple build and check on the latest R release (on a single OS, Mac) using github actions -- no travis/circle integration required.

usethis::use_github_action("check-release")

Results of the most recent check: https://github.com/signaturescience/skater/pull/14/checks?check_run_id=1936442062

It does take ~3-4 minutes because of all the package's dependencies but I'm not too worried about those.

If we add anything that might be OS specific we might switch out this quick check for the standard workflow that checks on Linux, MacOS, and Windows.

I still have restrictions on pushing to the master branch, but I removed the requirement for >=1 code review prior to merging (though this is still generally a good idea). There's now a new protection on the master branch that doesn't allow merging if the check fails.

vpnagraj commented 3 years ago

awesome!

might be on your list but id recommend we add a badge to the README too:

https://usethis.r-lib.org/reference/github_actions.html#use-github-actions-badge-

stephenturner commented 3 years ago

Ha! 5ddcad540c4e314c210012f5c740a6c4e2541e31

stephenturner commented 3 years ago

See the way this was broken up into two yamls, one on master, the other on nonmaster:

https://github.com/signaturescience/focustools/tree/pkg-build-ci/.github/workflows

https://github.com/signaturescience/focustools/pull/55