search

signavio / eslint-config-signavio

MIT License
3 stars 2 forks source link

Update eslint-config-airbnb #23

Open monapasan opened 6 years ago

monapasan commented 6 years ago

After upgrading eslint package we have following error:

(node:13878) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-config-airbnb-base/index.js")

This is caused by outdated eslint-config-airbnb package.

jfschwarz commented 6 years ago

I would actually vote for using a less opinionated eslint config that we do not have to extend and maintain on our own. For example, we could switch to the react-app one from create-react-app.

AnimiVulpis commented 6 years ago

@jfschwarz have you tried out if the current ESLint config and the one from create-react-app differ in some big ways? (Or have you tried @monapasan ?)

jfschwarz commented 6 years ago

The configs differ big time, which is the point for switching: create-react-app does not include too opinionated rules, which we might want to override.

The goal of the airbnb ruleset is a consistent code style, which is something that requires a lot of effort to maintain. Looking at the benefits we get from syntax consistency and comparing it with the burdens of migrating legacy code plus maintaining the ruleset, I'm not convinced it's worth it. This entire project (eslint-config-signavio) is treated as an orphan, which is why I would like to deprecate it.

There is no point in centralizing the eslint config across our different products in different repositories. The communication overhead is substantially greater. Autonomy of delivery teams should definitely include the ability to change linting rules without discussing with other teams.

AnimiVulpis commented 6 years ago

What I meant was: Are there rules that contradict rules of "create-react-app"

As for the rest of your comment :+1:

There was never real effort made to adhere to the style we choose.