Closed owlran closed 1 year ago
Latest commit: 690a90138ede19ea1f6e1774809673bbb63401e0
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
react-mentions | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 17, 2023 at 2:39AM (UTC) |
hi @atilafassina, could you please review this pr 🙏
I've added the dependencies in my fork as well and it's working fine, except when using customSuggestionsContainer which breaks
Fixes #663
What did you change (functionally and technically)? It was found that this problem occurred when the suggestionOverlay was refactored into a hook. see this commit Originally, the scroll position would be updated in componentDidUpdate, but in the hook version, it only does this in the initial effect.
so I fix effect's dependency to ensure scroll can be updated in correct time.