fix: fixes scroll into view in custom container elements

Sigrsig commented 1 year ago

Fixes issue: 674

What did you change (functionally and technically)? When attempting to scroll through the custom container elements an error would occur. I found that the custom container was being rendered inside the unordered list instead of around it. Rearranged the elements

Checklist (remove this list before you submit the PR)

Are there tests for the new code? No
Does the code comply to our code conventions? Yes
Does the PR resolve the whole issue? Yes

How to test:

Add maxHeight and overflowY: 'auto' to the list styling in SuggestionsOverlay.js
Run react-mentions and open on localhost
Scroll down to the custom container element
Pull up the suggestions list with the '@' button
Try scrolling through the list with the up and down buttons

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 931744fa97905a5ff05770fc0f763039381f7ea1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-mentions	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 31, 2023 2:52pm

signavio / react-mentions

fix: fixes scroll into view in custom container elements #677

🦋 Changeset detected