Closed gybadhan closed 9 months ago
Latest commit: ff359a741ad8960a2934608df6b196de36c52abe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
react-mentions | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 25, 2023 2:36pm |
Upgrading to latest version 4.4.10 seems to be working fine without any issue for MS Edge.
On MS Edge, type in some text and make at least one typographical error. Click on the typo to see suggested spellings and select one. If you select a corrected spelling, the text essentially doubles, leaving the corrected version and the uncorrected one.
Fixes #ABC
What did you change (functionally and technically)? -- Added extra check for null value for selectionStartBefore and selectionEndBefore in applyChangeToValue function.
Checklist (remove this list before you submit the PR)
Are there tests for the new code? Does the code comply to our code conventions? Does the PR resolve the whole issue? Additional review hints (remove this list before you submit the PR)
Besides the code review, what should the reviewer test? Are there any edge cases? Do you have any test files or test set-up? Could your changes cause side effects elsewhere in the code base?