signavio / react-mentions

@mention people in a textarea
https://react-mentions.vercel.app
Other
2.4k stars 560 forks source link

Added support to disable suggestion selection #719

Open jack-lewin opened 8 months ago

jack-lewin commented 8 months ago

I've picked up https://github.com/signavio/react-mentions/pull/440 to try and get it merged.

This PR adds an optional disabled prop to suggestions.

If a suggestion is disabled, it...

I've also...

If this lands, I'll make a separate PR to the DefinitelyTyped repo.

Feedback appreciated - cc @mastrix, @Sigrsig and @steffektif 🙏

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 247672b552b186c95dfb788503899d4b25b3a370

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | react-mentions | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 1:53pm
jack-lewin commented 8 months ago

Hi @Sigrsig & @steffektif, sorry for the nudge - are you still maintaining this project? If not, is there anyone else I should reach out to?

steffektif commented 8 months ago

Hey sorry, already the last time you reached out I pinged some people. Currently @PreussHendrik and @crecotun are in charge. I hope they see this message and can help you out

jack-lewin commented 8 months ago

Thanks a lot @steffektif - appreciate it 🙂

jack-lewin commented 3 weeks ago

Hi, @PreussHendrik and @crecotun!

I'd really appreciate a review here - might one of you be able to take a look please?

Let me know if there's anything I can do to help get this merged.

crecotun commented 1 week ago

Hi @jack-lewin Thank you for PR and for reaching out. I'll do my best to review it soon.