Added support to disable suggestion selection

signavio / react-mentions

@mention people in a textarea

https://react-mentions.vercel.app

Other

2.5k stars 575 forks source link

Added support to disable suggestion selection #719

Open jack-lewin opened 1 year ago

jack-lewin commented 1 year ago

I've picked up https://github.com/signavio/react-mentions/pull/440 to try and get it merged.

This PR adds an optional disabled prop to suggestions.

If a suggestion is disabled, it...

has a different style (reduced opacity, default cursor)
is not selectable & has aria-disabled = true
but still appears in the list

I've also...

added tests for the SuggestionsOverlay component & new functionality
updated the examples to disable one suggestion
updated the README accordingly

If this lands, I'll make a separate PR to the DefinitelyTyped repo.

Feedback appreciated - cc @mastrix, @Sigrsig and @steffektif 🙏

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 47b3c6861ce90a490e384815d1d12ebc8b3bd760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | react-mentions | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-mentions	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 26, 2024 3:16pm

jack-lewin commented 11 months ago

Hi @Sigrsig & @steffektif, sorry for the nudge - are you still maintaining this project? If not, is there anyone else I should reach out to?

steffektif commented 11 months ago

Hey sorry, already the last time you reached out I pinged some people. Currently @PreussHendrik and @crecotun are in charge. I hope they see this message and can help you out

jack-lewin commented 11 months ago

Thanks a lot @steffektif - appreciate it 🙂

jack-lewin commented 4 months ago

Hi, @PreussHendrik and @crecotun!

I'd really appreciate a review here - might one of you be able to take a look please?

Let me know if there's anything I can do to help get this merged.

crecotun commented 4 months ago

Hi @jack-lewin Thank you for PR and for reaching out. I'll do my best to review it soon.

jialiu54321 commented 3 months ago

Thank you for working on this! Hope this gets merged soon!

crecotun commented 3 months ago

It was a busy 2 weeks; I'll have a look at PR today @jialiu54321 @jack-lewin

jialiu54321 commented 3 weeks ago

hi, @crecotun, is there any update on this PR? Thank you!