uwApplication adaptations

signetlabdei / DESERT_Underwater

DESERT Underwater: an NS-Miracle extension to DEsign, Simulate, Emulate and Realize Test-beds for Underwater network protocols

http://desert-underwater.dei.unipd.it/

BSD 3-Clause "New" or "Revised" License

25 stars 20 forks source link

uwApplication adaptations #7

Closed torsten-pf closed 5 months ago

torsten-pf commented 1 year ago

Hi, for a uwApplication-derived addon to DESERT I need to change the code a little bit:

added function send_buf() to send payload to the socket (needs to get overridden in derived class)
command(): removed class specifiers in calls to openConnectionTCP() and openConnectionUDP() to call overriding function if available

fedefava86 commented 1 year ago

@torsten-pf Thanks for your contribution. It will be reviewed asap. I understand from the PR itself that you are gonna develop an add-on based on uwApplication. Are you gonna submit it? If so, you could push it here so we can do a single review.

fedefava86 commented 1 year ago

@torsten-pf Any news on this? are you willing to submit also the module which is inheriting from uwApplication ? We are not against make this PR entering, but is pointless IMHO to make different PR in the same context. Let us know what is your plan, please. Thanks

torsten-pf commented 1 year ago

@fedefava86 Sorry, I didn't have time to work on the app module. Since I use WSL2 for development, I had some problems with UDP sockets that I wanted to use to send position data to DESERT. Also, I have a few dependencies on external modules in the current version that I want to resolve.