Open JacoTuks opened 2 years ago
According to The LoRa Modem Designer's guide, the duration of a preamble is (nPreamble + 4.25)*Tsym but in class-a-end-device-lorawan-mac.cc the +4.25 is omitted.
Both receive windows are scheduled to close too fast.
class-a-end-device-lorawan-mac.cc
m_closeFirstWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseFirstReceiveWindow, this); //m_receiveWindowDuration
m_closeSecondWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseSecondReceiveWindow, this);
Please let me know if I have missed something? I will happily create a pull request if you agree that this is an issue.
Expected Behavior
According to The LoRa Modem Designer's guide, the duration of a preamble is (nPreamble + 4.25)*Tsym but in class-a-end-device-lorawan-mac.cc the +4.25 is omitted.
Actual Behavior
Both receive windows are scheduled to close too fast.
Code in question
class-a-end-device-lorawan-mac.cc
m_closeFirstWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseFirstReceiveWindow, this); //m_receiveWindowDuration
m_closeSecondWindow = Simulator::Schedule (Seconds (m_receiveWindowDurationInSymbols*tSym), &ClassAEndDeviceLorawanMac::CloseSecondReceiveWindow, this);
Specifications
Please let me know if I have missed something? I will happily create a pull request if you agree that this is an issue.