fixing assertion fails in phy-communication-test

signetlabdei / lorawan

An ns-3 module for simulation of LoRaWAN networks

GNU General Public License v2.0

185 stars 131 forks source link

Closed MichaelCTH closed 6 years ago

MichaelCTH commented 6 years ago

This pull request fixes assertion fails in phy-communication-test.cc

Change the SF to 7 in line 161&223, as the SF7 is the default for all EndDeviceLoraPhy instances.
Change trace context to 'LostPacketBecauseWrongFrequency' in line 140-142, since the 'LostPacketBecauseNoMoreReceivers' has never been declared.
Also rename the 'LostPacketBecauseWrongFrequency' associated callback function and variable for consistency and easy understanding. :)

DvdMgr commented 6 years ago

Hi, everything seems to be in order! I must have forgotten to update the default SF in this example, and the Trace Source makes a lot more sense now.

Thanks for the pull request!

MichaelCTH commented 6 years ago

Btw, nice work! Thank you @DvdMgr for putting up such a great module. :)