signetlabdei / lorawan

An ns-3 module for simulation of LoRaWAN networks
GNU General Public License v2.0
185 stars 131 forks source link

Add 'lorawan-' to the example program names for running with waf #47

Closed peggyopal closed 4 years ago

peggyopal commented 4 years ago

This pull request fixes issue #46

Proposed Changes

DvdMgr commented 4 years ago

Thanks for pointing this out!

I feel that changing the name of the program from the wscript could break the existing workflow of users, and I don't really like having the program name differ from the filename.

Of the two solutions you propose, I'd rather modify the README to have the example names be complete-network-example and simple-network-example!

peggyopal commented 4 years ago

Done!

DvdMgr commented 4 years ago

Perfect, merged! Thank you!