Extract Class A End Device Type functionality into its own class

signetlabdei / lorawan

An ns-3 module for simulation of LoRaWAN networks

GNU General Public License v2.0

185 stars 131 forks source link

Extract Class A End Device Type functionality into its own class #53

Closed peggyopal closed 4 years ago

peggyopal commented 4 years ago

This pull request works towards issue #39 This pull request fixes issue #54

Proposed Changes

Add ClassAEndDeviceLorawanMac class that extends EndDeviceLorawanMac
- Remove Class A ED specific functionality from EndDeviceLorawanMac to new class
Change DeviceType ED to ED_A in lorawan-mac-helper.cc in anticipation for the addition of Class C ED
Update Tests/Examples to use ClassAEndDeviceLorawanMac
Some private variables in EndDeviceLorawanMac were made protected

DvdMgr commented 4 years ago

Peggy, I completed my review, thank you for this contribution!

I was able to spot a bug that caused receive windows to be closed immediately, making downlink communication impossible - however, I easily fixed it by initializing the m_receiveWindowDurationInSymbols variable to 8.

Other than that this pull request looks good to me, but it also highlighted how we need more tests to ensure the MAC works as expected - I might be able to get some students to work on this, we'll see. We'll keep this on the develop branch for a bit, so that if other issues surface we can take care of them without disturbing the main branch - however you can definitely base your further work upon this contribution, with the certainty that it will make it to master eventually.

DvdMgr commented 4 years ago

Rebased on develop and pushed, thanks again!