ACK bit set wrongly at EndDeviceLorawanMac?

signetlabdei / lorawan

An ns-3 module for simulation of LoRaWAN networks

GNU General Public License v2.0

190 stars 132 forks source link

ACK bit set wrongly at EndDeviceLorawanMac? #67

Closed theelbowclaps closed 4 years ago

theelbowclaps commented 4 years ago

Expected Behavior

In void EndDeviceLorawanMac::ApplyNecessaryOptions (LoraFrameHeader& frameHeader), the frameHeader ACK bit should only be set if the end device has just received a confirmed downlink message.

Actual Behavior

The ack bit is set based on Uplink message type. Ack = 1 if mType = CONFIRMED_DATA_UP.

Steps to Reproduce the Problem

N/A

Specifications

N/A

DvdMgr commented 4 years ago

You are right, this is wrong. Removed the check + setting of the ACK bit in 80eb5243bb3ee77eeaa409531fa90aaae9965941, since we don't support ACKs sent by EDs yet.

Thanks for pointing this out!