search

significa / ios-swiftui-tca-example

PokemonCards - SwiftUI + Composable Architecture Example
101 stars 6 forks source link

Snapshot tests failing #2

Open paulz opened 2 years ago

paulz commented 2 years ago

First of all thank you for the great example repo!

Is there a specific device snapshot tests should be passing?

When I ran on Xcode 13.4.1 (13F100) with iPhone 12 Pro all snapshots tests fail with minor differences to images:

image image

This one looks completely black: difference_3_7C1DAF00-6BEA-4626-B3B3-3022DBBFE948

and when I use auto levels in preview it shows: image

complete test results archive: Test-Staging-2022.07.05_21-08-33--0700.xcresult.zip

dfalmeida commented 1 year ago

Hi @paulz. Thanks for showing your interest in our example 👍

I just tested it locally with macOS 12.3, Xcode 13.4.1 (13F100) and the simulator with an iPhone 12 Pro. The tests are failing because the snapshots do not match. The native components/icons we are using on the app were changed since our last PR. We will try to update it soon 😅 All the screenshots were generator as expected.

Regarding your specific problem, I didn't experienced nothing similar in the past. It seems something is wrong when taking the screenshots, maybe related with the OS itself 🤔 Which version of macOS are you using?

Edit: Can you re-test it on your side? I just merged #1 with changes to the snapshots