search

signmeup / signmeup

Real-time application to sign up for and manage TA hours.
https://signmeup.cs.brown.edu
MIT License
96 stars 33 forks source link

Improve queue page title for students #264

Closed j-f1 closed 4 years ago

j-f1 commented 4 years ago

Currently, the queue page shows the total number of tickets in the queue for both TAs and students. While useful for TAs who are there to help all the students, the most pressing concern for a typical student — like me! — is “when will the TA help me?” This PR attempts to answer this question for students by showing them the number of tickets that are in line ahead of them, and hiding the number icon when the student doesn’t have any tickets waiting so they aren’t distracted while working.

This is my first time contributing to either this project or a Meteor project in general, so any feedback would be appreciated.

gregcarlin commented 4 years ago

Thanks for the submission! What do you think about keeping the existing count for anyone that doesn't have a ticket in the queue, rather than just TAs?

j-f1 commented 4 years ago

This was my personal feeling about that, but I’m happy to change it too.

[hide] the number icon when the student doesn’t have any tickets waiting so they aren’t distracted while working.

gregcarlin commented 4 years ago

Love it, thanks so much!

j-f1 commented 4 years ago

Hey @gregcarlin, what’s the process to get this deployed to signmeup.cs.brown.edu?

gregcarlin commented 4 years ago

I have a meeting scheduled with @rc9575 on 11/17 - we should be able to deploy it then. Thanks for waiting!