search

signnow / SignNowPHPSDK

The Official SignNow PHP SDK library for interacting with SignNow REST API. Sign documents, request e-signatures, and build role-based workflows with multiple signers using this client.
https://www.signnow.com/developers
MIT License
9 stars 10 forks source link

$updateHttpMethod = Request::METHOD_PATCH #2

Closed keithslater closed 2 years ago

keithslater commented 4 years ago

I believe the updateHttpMethod should be a PUT

falgonua commented 4 years ago

Hello @keithslater. Yes, you are right. In case of https://github.com/signnow/SignNowPHPSDK updateHttpMethod should be PUT. You could set it via EntityManager::setUpdateHttpMethod(string $updateHttpMethod). Its described in readme https://github.com/signnow/SignNowPHPSDK#setting-up. https://github.com/signnow/RestEntityManager is developed without any dependencies of our API. And we decided use PATCH method as default between PUT/PATCH for EntityManager::update(Entity $entity, $uriParams = [], $queryParams = [], array $headers = []).