signnow / SignNowPHPSDK

The Official SignNow PHP SDK library for interacting with SignNow REST API. Sign documents, request e-signatures, and build role-based workflows with multiple signers using this client.
https://www.signnow.com/developers
MIT License
8 stars 10 forks source link

Signing Link Expiration does not accept null #22

Closed matthewhutchings closed 1 year ago

matthewhutchings commented 1 year ago

as per documentation:

In your request specify: "auth_method" - signer authentication menthod; can be "password", "email", "mfa", "social", "biometric", "other", "none" "link_expiration" - in how many minutes the link expires, ranges from 15 to 45 minutes or null. https://docs.signnow.com/docs/signnow/aaa2c15d291c3-generate-a-link-for-embedded-invite

However:

   public function setSigningLinkExpiration(
        string $documentUid,
        string $fieldInviteUniqueId,
        int $expiration,
        ?AuthMethodInterface $authMethod = null
    ) {

int $expiration should allow null

darnel868 commented 1 year ago

Did this problem fix?

JiSoft commented 1 year ago

Fixed at v2.2.3 v1.5.3