search

signum-network / signum-explorer

Signum Blockchain Explorer
GNU General Public License v3.0
9 stars 11 forks source link

Enhancement: Preview Alias Transfer Transaction #140

Open ipr0310 opened 1 year ago

ipr0310 commented 1 year ago

As the title says when transferring an alias the transaction preview has a little typo, it is mis-labeled

Additional context Technically, an alias on private sale with 0 as price immediately transfers the alias to the receiver.

Expected behavior When the explorer detects an alias private sell with the price of 0, it should be labeled as Alias Transfer

ipr0310 commented 1 year ago

Transaction Link https://testnet.explorer.signum.network/tx/18023758478911975784

pir8radio commented 5 months ago

we just grab whats in the node database. how is it stored on chain? as a SELL or Transfer?

ipr0310 commented 5 months ago

SELL with price of 0

Selling something for 0 SIGNA

pir8radio commented 4 months ago

wouldnt that still be a sale? If i sell you my car for .0000001 or just 0 we made a deal and i sold it. or other way around, if i sell you my car for $100 wouldnt that be a transfer of ownership.. should all sales be called transfers instead? since they all transfer to a new owner no matter the price 100000 or 0?

ipr0310 commented 4 months ago

That's how we do on SignumSwap for alias transfer, sell an alias for 0 SIGNA, and automatically the alias gets transferred