search

signum-network / signum-explorer

Signum Blockchain Explorer
GNU General Public License v3.0
9 stars 11 forks source link

Fix: issue #76 #157

Closed Antoninich closed 9 months ago

Antoninich commented 10 months ago

It is more correct to change the description line in signum-node. image

pir8radio commented 10 months ago

I would rather not do one off things, i hope that the devs change this description to match SRC44 so we can just decode it like we do everything else in the explorer.

Example this: image

Becomes this: image

ohager commented 9 months ago

I would rather not do one off things, i hope that the devs change this description to match SRC44 so we can just decode it like we do everything else in the explorer.

Example this: image

Becomes this: image

I mentioned it here... The NFT was created before SRC44... the contracts descriptor is not SRC44 compatible, but if you resolve the IPFS hash in the descriptor you get a JSON with all media data. Changing the descriptor for NFT contracts now, is much more effort than treating it in the explorer tbh. We have an entire backend and some additional tools that uses the non-SRC44 format

Here is an example of the JSON in referenced in NFT descriptor field. https://ipfs.io/ipfs/bafkreifgan3pg344vhz3tnjq26mzfmt4cmxy5lb6y74jkxobrz4xzq54lm

from this NFT https://chain.signum.network/at/2978638295822152791

ohager commented 9 months ago

We are changing the NFTs description to be SRC44 compatible... I think we can close this PR.

pir8radio commented 9 months ago

closing, thanks @ohager