signum-network / signum-miner

The official signum-network miner
GNU General Public License v3.0
17 stars 4 forks source link

Possible Bug in "submission not accepted" error message #11

Open paulpoco opened 3 years ago

paulpoco commented 3 years ago

Possible Bug in "submission not accepted" error message.

To recreate: submit_only_best: false target_deadline: 2000000

In this case it looks like the real reason the deadline wasn't accepted was because a new block was starting 1 sec later, so it was actually rejected for wrong round and not "message: {"result":"Deadline exceeds maximum allowed deadline"}"

Since when does 266,630 exceed 2,000,000?

Now I am doing the max target deadline at 2,000,000 and send all to catch short blocks but not send super high deadlines that would happen if it was send all from the very beginning using the target_deadline=1,000,000,000. If it was target_deadline=1,000,000,000 and send all and a super short block, it would cause my EC to usually cut in half because the miner didn't get a chance to read all the plots and the chain/pool thinks you are way smaller.

How did I pick target_deadline: 2000000? I used the pool API and my address to get my deadlines, and only a few out of about 119 were larger like: 1812641 1193214 1520451 1635704 1102099 1480708 1238251 1439041 1563917 1032434 So I figured 2,000,000 would catch everything.

image

jjos2372 commented 3 years ago

This can happen when the pool is already on another block and so the nonce sent (for the wrong block) will very likely exceed the maximum allowed.