search

signum-network / signum-miner

The official signum-network miner
GNU General Public License v3.0
17 stars 4 forks source link

Replace yanked dependency #13

Closed Creepsky closed 2 months ago

Creepsky commented 2 years ago

https://github.com/jonas-schievink/aligned_alloc.rs has been deprecated. All versions on crates.io have been yanked, so the build fails. This PR should fix this problem. Fixes #12.

Additionally, one of the unit tests failed, which I fixed.

damccull commented 6 months ago

This probably needs tested then merged. Been around a long time. Doesn't look like it should cause issues off the bat but I'm no memory alignment expert.

damccull commented 2 months ago

I'd prefer #16 over this. It removes more unsafe and changes less to get it working again.

Creepsky commented 2 months ago

Sure thing, I'll just close this one then 😄

damccull commented 2 months ago

@Creepsky I thought you had disappeared into the void!

Sure thing, I'll just close this one then 😄

Wanna help rewrite this thing to use current versions? I was just discussing that with gitrekt and it'll be a but if a project it seems.

pir8radio commented 2 months ago

Sure thing, I'll just close this one then 😄

Pretty cool to see you back contributing! Creepminer creator and all! :-)

damccull commented 2 months ago

Indeed. I used creepminer for the first 3 years of my burst coin experience I think. It was a long time.

Creepsky commented 1 month ago

I feel flattered that there are people who still know me :) peak Burst time was awesome!

I am pretty sure I can dedicate some free time to help you rewrite it, let me know when you have some concrete plans, might be an interesting project.