signum-network / signum-xt-wallet

Cryptocurrency wallet for the green Signum 🍀 blockchain as an extension for your browser.
MIT License
14 stars 6 forks source link

Not able to import an existing account as first step #23

Closed frankTheTank72 closed 2 years ago

frankTheTank72 commented 2 years ago

Describe the bug I installed XT on Brave. I tried to import an existing account as first step. Brave shows an error after i added the passphrase and hit the button.

Expected behavior Should be able to add an existing account as first step on Brave.

Screenshots brave1

Browser (please complete the following information):

Additional context Add any other context about the problem here.

paulpoco commented 2 years ago

Same on Chrome

ohager commented 2 years ago

Not reproducible

Neither on Chrome, nor on Brave

Tested on:

Version 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit) Version 98.0.4758.102 (Official Build) (64-bit)

ohager commented 2 years ago

Ok. I have a theory what happened. I need to assume that you waited for a certain time (like 5 minutes) before you started to import. Background: The Manifest Version 3 runs so called service workers, which goes "offline" (being inactive) after a certain time period. When this happens, the service worker disconnects from the Messaging API. So the port being used does not exist anymore....and causing a communication faiilure. I was able to reproduce this on the signumart platform. I waited until the service worker became inactive and tried to sign a transaction, which caused an error then.

Google did an awesome job. Congrats!

Just for the records: Service Worker do not go inactive when using Developer Mode :roll_eyes:

ohager commented 2 years ago

I close this as duplicate of #24