search

signum-network / signumjs

SignumJS - Javascript SDK for Signum
https://docs.signum.network/signum/signumjs
Apache License 2.0
17 stars 8 forks source link

Add support for STLDs in `setAlias` method on `DescriptorDataBuilder` class #57

Closed ipr0310 closed 1 year ago

ipr0310 commented 1 year ago

Is your feature request related to a problem? Please describe. As the upcoming node version is bringing changes on Alias Framework, which means that STLDs are relatively new. the setAlias method will need to support the upcoming new alias format: https://github.com/signum-network/SIPs/pull/90 image

Describe the solution you'd like Update the setAlias method in order to support STLDs

This is the Regex statement /^(\w+)(?:\.(\w+))?$/g

ohager commented 1 year ago

It's alias:tld and not tld.alias

https://github.com/signum-network/signumjs/blob/main/packages/standards/src/src44/validateSRC44.ts#L51