search

sigopt / sigoptlite

Optimize with SigOpt with this standalone SigOpt client driver.
Apache License 2.0
8 stars 1 forks source link

force parameter types #17

Closed malkomes closed 1 year ago

malkomes commented 1 year ago
Chris-Sigopt commented 1 year ago

Is the goal to replace all of the ValueErrors one type at a time with the appropriate SigoptValidationError? I'm not understanding why we now throw one InvalidTypeError and everything else is a ValueError.

malkomes commented 1 year ago

Is the goal to replace all of the ValueErrors one type at a time with the appropriate SigoptValidationError? I'm not understanding why we now throw one InvalidTypeError and everything else is a ValueError.

yes @Chris-Sigopt that's my plan: replace all ValueErrors that we intentionally raise to the appropriate the SigoptValidationError; which means that we will be reserving the stdlib exceptions to things that we didn't anticipate --- hopefully the latter never happens, thou 🤞