search

sigp / enr

Ethereum Node Record
MIT License
61 stars 29 forks source link

Enr Debug implementation is unhelpful #13

Closed mattsse closed 1 year ago

mattsse commented 1 year ago

The current debug impl of Enr

https://github.com/sigp/enr/blob/e59dcb45ea07e423a7091d2a6ede4ad6d8ef2840/src/lib.rs#L864-L868

is unhelpful for debugging.

The display impl is more helpful for debugging but lacks content info

https://github.com/sigp/enr/blob/e59dcb45ea07e423a7091d2a6ede4ad6d8ef2840/src/lib.rs#L852-L862

Suggest flipping them and to include k,v pairs as well.

divagant-martian commented 1 year ago

Sounds like a good suggestion! Are you planning on providing a PR for this?

mattsse commented 1 year ago

great, will do!