search

sigp / enr

Ethereum Node Record
MIT License
61 stars 29 forks source link

Serialize NodeId with `0x` prefix #38

Closed KolbyML closed 1 year ago

KolbyML commented 1 year ago

So in my og pr divagant-martian asked me if I wanted to use a 0x prefix or not and at the time I said that it didn't matter to me. I just had a meeting today and my team said they want a prefix since it ensures consistence with hex values, and it makes it easier to identify it as hex. It thought that was fair. So I am here today to try and get a 0x prefix :shipit:

KolbyML commented 1 year ago

@divagant-martian @AgeManning ping for review

njgheorghita commented 1 year ago

@divagant-martian Hey! Any eta for when the next release of this library will be cut?

divagant-martian commented 1 year ago

Start of next week we can cut a release. Not this one though, sorry

njgheorghita commented 1 year ago

That's great, thanks a lot!