sigp / enr

Ethereum Node Record
MIT License
61 stars 29 forks source link

deps: replace serde-hex with custom serialize #45

Closed jxs closed 1 year ago

jxs commented 1 year ago

closes #44

divagant-martian commented 1 year ago

This does not achieve the desired output.

Current way has a 0x prefix, and this change removes the prefix.

What's the motivation for this change?

divagant-martian commented 1 year ago

Just saw #44 , could you link to the relevant issues next time to understand the context?

That being said, all in favor for removing a dep that's there just for this, but the output should remain the same. We could just create the module that does the prefix prepending and stripping and relies on hex underneath


extra context: https://github.com/sigp/enr/pull/38

jxs commented 1 year ago

created https://github.com/sigp/enr/pull/49 to address the clippy lints

divagant-martian commented 1 year ago

@jxs can you merge master to get this one in?

jxs commented 1 year ago

@jxs can you merge master to get this one in?

yup, done! :)