search

sigp / lighthouse-metrics

A docker-compose with Grafana + Prometheus for monitoring Lighthouse
145 stars 49 forks source link

Listen on localhost only by default #17

Closed michaelsproul closed 3 years ago

michaelsproul commented 3 years ago

Prevent Prometheus and Grafana from binding to all interfaces by default

michaelsproul commented 3 years ago

Could also consider never binding Prometheus on 0.0.0.0, even in the public env?

zedt3ster commented 3 years ago

Could also consider never binding Prometheus on 0.0.0.0, even in the public env?

I think defaulting to listening to localhost, and allowing users to explicitly expose that endpoint is good.

michaelsproul commented 3 years ago

Yeah, I agree. Let's merge