Open ackintosh opened 2 years ago
In lighthouse, the client is used to:
beacon_node/http_metrics
cratevalidator_client/http_metrics
cratemonitoring_api
crateThe metrics is defined as Ethereum consensus client metrics and Beacon chain metrics.
:wave: libp2p
and prometheus-client
maintainer here.
Another benefit would be dependency consolidation. libp2p
uses prometheus-client
and in turn the lighthouse network stack uses prometheus-client
.
đź“ť I'm working on https://github.com/prometheus/client_rust/pull/47. This makes the client able to do our the 2.
use case I've mentioned here.
đź“ť I found out that lighthouse is using HistogramTimer, which is timer to measure and record the duration of an event. (e.g. here)
For now, if I understand correctly, the official client doesn’t have a functionality equivalent to HistogramTimer.
I find HistogramTimer
a need feature of the prometheus
crate. I think it is worth proposing it to the prometheus-client
crate @ackintosh.
Description
Prometheus team have released an official Prometheus instrumentation library for Rust.
https://github.com/prometheus/client_rust
We're not having any problems with the current client for now, however, I believe we would take benefits from the official one. ref: https://github.com/tikv/rust-prometheus/issues/392