sigp / lighthouse

Ethereum consensus client in Rust
https://lighthouse.sigmaprime.io/
Apache License 2.0
2.88k stars 724 forks source link

Panic connecting v2.1.1 VC to v2.0.1 or earlier BN #2958

Closed michaelsproul closed 2 years ago

michaelsproul commented 2 years ago
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: FromHexError { inner: InvalidStringLength }', consensus/types/src/chain_spec.rs:694:10

See https://github.com/sigp/lighthouse/pull/2957 for more information

joe-bowman commented 2 years ago

I was able to replicate this earlier too; what's the plan here, upgrade beacon nodes first?

michaelsproul commented 2 years ago

I was able to replicate this earlier too; what's the plan here, upgrade beacon nodes first?

Yeah. In the release notes for v2.1.0 and v2.1.1 we signalled an intention for the v2.1.x validator not to be compatible with the v2.0.1 BN, so the recommended upgrade path remains the same: upgrade the BNs, and then the VCs shortly after (or in the same update). This panic is just an unsightly error rather than a clean failure.

joe-bowman commented 2 years ago

Excellent, thank you for your swift response!

Sent from my iPhone

On 29 Jan 2022, at 10:46, Michael Sproul @.***> wrote:

 I was able to replicate this earlier too; what's the plan here, upgrade beacon nodes first?

Yeah. In the release notes for v2.1.0 and v2.1.1 we signalled an intention for the v2.1.x validator not to be compatible with the v2.0.1 BN, so the recommended upgrade path remains the same: upgrade the BNs, and then the VCs shortly after (or in the same update). This panic is just an unsightly error rather than a clean failure.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.

michaelsproul commented 2 years ago

Fixed in v2.1.2